langchain: included concurrency limit in RecursiveUrlLoader #15537
+30
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
baskaryan
reviewed
Jan 15, 2024
| return [] | ||
|
|
||
| # Wait if the concurrent requests limit is reached | ||
| if semaphore.locked(): |
There was a problem hiding this comment.
what's this needed for, doesn't L241 already handle this?
There was a problem hiding this comment.
I included it to allow the loader to complete as many requests as possible once the limit is reached before sending other requests. My idea was to insert a delay to avoid HTTP errors caused by an excessive number of simultaneous requests.
If you think that's redundant I can quickly update the code.
There was a problem hiding this comment.
@baskaryan could you please tell me if I need to update the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concurrent_requests_limitargument.asyncio,time.